d_s_bisht/devsofttech_hms_ci4
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(abha-create): handle and sanitize upstream ABDM 500 error on address suggestions gracefully

Browse Source
This commit is contained in:
DevSoftTech Server 2026-10-24 13:09:50 +05:30
parent 5f9784d7ec
commit 43d52163ab
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Controllers/Abha.php
View File

@ -1549,13 +1549,17 @@ class Abha extends BaseController
// A missing Bridge endpoint must not block ABHA creation — the modal
// keeps the ABDM-assigned address and skips the selection step.
$unsupported = in_array((int) ($result['http_code'] ?? 0), [404, 405], true);
$bridgeErr = $this->extractBridgeErrorText($result, 'Unable to load ABHA address suggestions.');
if (stripos($bridgeErr, 'Internal Server Error') !== false || (int) ($result['http_code'] ?? 0) >= 500) {
$bridgeErr = 'Suggested ABHA addresses are temporarily unavailable from ABDM.';
}
return $this->response->setJSON([
'ok' => 0,
'supported' => ! $unsupported,
'error_text' => $unsupported
? 'The ABDM Bridge does not expose ABHA address suggestions yet.'
: $this->extractBridgeErrorText($result, 'Unable to load ABHA address suggestions.'),
: $bridgeErr,
'request_id' => (string) ($result['request_id'] ?? ''),
]);
}

17
app/Views/partials/abha_create_modal.php
View File

@ -383,6 +383,9 @@ window.AbhaCreateModal = (function () {
var raw = response && (response.error_text || response.message)
? String(response.error_text || response.message)
: fallback;
if (/Internal Server Error/i.test(raw)) {
raw = 'ABDM server is temporarily unavailable';
}
if (/loginId/i.test(raw) && /invalid/i.test(raw)) {
raw = 'Aadhaar Number is not valid. Valid 12-digit Aadhaar number is required.';
}
@ -793,7 +796,12 @@ window.AbhaCreateModal = (function () {
$.post('<?= base_url('abha/create/address_suggestions') ?>', { txn_id: createTxnId, '<?= csrf_token() ?>': csrf() }, function (response) {
if (!response || response.ok != 1 || !(response.suggestions || []).length) {
$('#abhaCreateAddressList').html('<div class="alert alert-warning py-2 mb-0">' + apiMessage(response, 'No suggested ABHA addresses are available from the bridge.') + ' Please enter a custom address below.</div>');
var msg = apiMessage(response, 'Suggested ABHA addresses are temporarily unavailable from ABDM.');
if (/Internal Server Error/i.test(msg) || /500/.test(msg)) {
msg = 'Suggested ABHA addresses are temporarily unavailable from ABDM.';
}
msg = msg.replace(/\.+$/, '');
$('#abhaCreateAddressList').html('<div class="alert alert-info py-2 mb-0"><i class="bi bi-info-circle me-1"></i>' + msg + '. Please enter your preferred custom address below.</div>');
$('#abhaCreateCustomWrap').removeClass('d-none');
return;
}
@ -806,7 +814,12 @@ window.AbhaCreateModal = (function () {
});
$('#abhaCreateAddressList').html(html);
}, 'json').fail(function (xhr) {
$('#abhaCreateAddressList').html('<div class="alert alert-warning py-2 mb-0">' + apiMessage(xhr.responseJSON, 'Unable to load address suggestions.') + ' Please enter a custom address below.</div>');
var msg = apiMessage(xhr.responseJSON, 'Suggested ABHA addresses are temporarily unavailable from ABDM.');
if (/Internal Server Error/i.test(msg) || /500/.test(msg)) {
msg = 'Suggested ABHA addresses are temporarily unavailable from ABDM.';
}
msg = msg.replace(/\.+$/, '');
$('#abhaCreateAddressList').html('<div class="alert alert-info py-2 mb-0"><i class="bi bi-info-circle me-1"></i>' + msg + '. Please enter your preferred custom address below.</div>');
$('#abhaCreateCustomWrap').removeClass('d-none');
});
}