d_s_bisht/devsofttech_hms_ci4
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix misleading 'fetched successfully' message on Fetch Records when no documents were actually saved

Browse Source 
abdm_content_fetch_only() always returned phase=COMPLETED and 'Records fetched successfully' whenever the data_fetch API call itself succeeded (fetchResult.ok===1), even when documents_persisted+documents_updated was 0 (bridge/HIP hasn't actually delivered any records yet -- decrypted_data still empty, session status 'requested'). Now check documents_persisted+documents_updated: if 0, report phase=GRANTED with a clear 'not sent any records yet' message instead of falsely claiming success.
This commit is contained in:
DevSoftTech Server 2026-07-29 02:08:25 +05:30
parent afd1de04bf
commit 690dbf9572
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/Controllers/Patient.php
View File

@ -2061,12 +2061,32 @@ class Patient extends BaseController
]);
}
// `$fetchResult['ok'] === 1` only means the API call to the bridge
// succeeded (no HTTP/transport error) — it does NOT mean the HIP has
// actually sent any health records yet (the bridge may legitimately
// respond with an empty decrypted_data set while still processing).
// Only report success to the user once documents were actually saved;
// otherwise say plainly that the fetch is still pending.
$documentsPersisted = (int) ($fetchResult['documents_persisted'] ?? 0);
$documentsUpdated = (int) ($fetchResult['documents_updated'] ?? 0);
if ($documentsPersisted + $documentsUpdated === 0) {
return $this->response->setJSON([
'ok' => 1,
'phase' => 'GRANTED',
'message' => 'Consent is granted, but the health information provider has not sent any records yet. Please try again in a few minutes.',
'documents_persisted' => 0,
'documents_updated' => 0,
'data' => ['data_fetch' => $fetchResult],
]);
}
return $this->response->setJSON([
'ok' => 1,
'phase' => 'COMPLETED',
'message' => 'Records fetched successfully using existing granted consent.',
'documents_persisted' => (int) ($fetchResult['documents_persisted'] ?? 0),
'documents_updated' => (int) ($fetchResult['documents_updated'] ?? 0),
'documents_persisted' => $documentsPersisted,
'documents_updated' => $documentsUpdated,
'data' => ['data_fetch' => $fetchResult],
]);
}